Add TCP alert handler #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
| } | ||
|
|
||
| conn, err := net.Dial("tcp", tcp.Address) |
There was a problem hiding this comment.
Would it be possible to reuse the same TCP connection and use the Write method to send individual packets for each event? Not sure if that would break the server side.
There was a problem hiding this comment.
I had considered that, but it seemed like it would be a pretty large undertaking. I'm assuming it would require some connection pooling per handler, with some mechanisms for checking the health of the connections (and maybe closing connections after a longer period of inactivity). Not sure if that's way off base or not, though.
I'd be up for discussing it more in depth offline if you have some time.
rossmcdonald
force-pushed
the
ross-tcp-alert
branch
from
d304f48
to
8e42b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs