Change 'enterprise-client' to 'usage-client' #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timraymond Thanks this looks good, yeah when I heard things were changing I realized I was going to need to do some rework. It won't be too hard. Can we get together for chat soon to make sure I understand the direction so I can make appropriate changes? |
|
@nathanielc Certainly! I'll find you in Slack and we'll set something up. |
| client := client.New(token) | ||
| client.URL = c.EnterpriseURL | ||
| func NewService(c Config, l *log.Logger) *Service { | ||
| client := client.New("") |
There was a problem hiding this comment.
@timraymond I don't need the token any more correct?
There was a problem hiding this comment.
@nathanielc Yep, that's fine ✂️ . The empty string token is the same approach we've taken in Chronograf and Core for usage-only reporting.
|
@timraymond Overall is this what you expected? |
Enterprise Client will soon become something else entirely, so the existing enterprise-client has become 'usage-client'. The existing enterprise service now only records usage data, and discards everything else. This changes Kapacitor to use 'usage-client'.
nathanielc
force-pushed
the
usage-client
branch
from
2703b65
to
7b63a4e
Compare
|
@nathanielc Yep! This looks good to me 👍 |
nathanielc
pushed a commit
that referenced
this pull request
Dec 14, 2015
Change 'enterprise-client' to 'usage-client'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enterprise-clientwill soon be repurposed for the on-prem solution, so we have renamed the existingenterprise-clienttousage-client. It provides the same interface, but the backend endpoints for everything except anonymous usage reporting have been no-oped. I attempted to remove stats reporting from Kapacitor, however it seems thatclient.StatsDatais used internally to facilitate writing TICK scripts against Kapacitor's own stats. Since this will require a bit more care than originally thought, for the time being this patch only switches the repos so that everything is reported tousage.influxdata.cominstead ofenterprise.influxdata.com(since we are repurposing that subdomain as well).