feature: add size for humanize byte size #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsvisa
commented
Jun 23, 2016
•
jsvisa
commented
- Rebased/mergable
- Tests pass
- CHANGELOG.md updated
jsvisa
force-pushed
the
feature/humanize-helpers
branch
from
ef4c0b6
to
34e86f0
Compare
| v = humanize.Bytes(uint64(int64(a))) | ||
| case int64: | ||
| v = humanize.Bytes(uint64(a)) | ||
| case uint64: |
There was a problem hiding this comment.
This case isn't necessary as all ints will be int64s.
jsvisa
force-pushed
the
feature/humanize-helpers
branch
from
34e86f0
to
7bd32bb
Compare
|
@nathanielc Apologies for the delay. I'm just updated as what you mentioned. |
|
@jsvisa Thanks! |
|
may i know from which kapacitor version the function humanize is supported. could you please let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.