Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expire groups after X number of zero events #610

Closed
wants to merge 1 commit into from
Closed

Conversation

nathanielc
Copy link
Contributor

@nathanielc nathanielc commented Jun 3, 2016

Expire a group after X number of stats points are received with zero value.

This allows for deaman groups to expire after giving an alert.

TODO

  • Test inverted deadman, aka alert on high counts
  • Be able to disable expiring alerts for deadman method
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

Some thoughts:

Maybe we want to extend this kind of logic beyond just the StatsNode. All nodes would benefit from being able to free up resources for expired groups. There should probably be two ways to expire groups.

  1. Implicitly via some sort of timeout or zero count (like the PR is already doing)
  2. Explicitly via an API call, so it can be managed externally to Kapacitor. (i.e. shutdown hook when a server is being retired)

@nathanielc
Copy link
Contributor Author

Closing since this is no longer a valid solution. See #1157

@nathanielc nathanielc closed this Jan 31, 2017
@nathanielc nathanielc deleted the nc-issue#598 branch April 26, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant