update batch group stats to be by len(b.Points) #605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So there are several stats that Kapacitor keeps track of, and they have different uses.
kapacitor show
command under processed.Depending on the edge type the counters count different things.
For Stream edges its simple. The counters always count the number of points emitted or collected.
For batch its different. You can count the number of batches or the number of points in each batch. Both counts are important as such this PR changes the behavior so we can capture both values.
Above first counters count the number of batches the edge has processed. The second counters by group count the number of points per batch. Which if an empty batch is emitted means the counter will not increase. (NOTE: empty batches are preserved now from
where
filters etc, but still not produced from QueryNodes , see #595)In summary if the StatsNode will report the number of points processed for each group independent of edge type. The basic edge counters report number of points for stream and number of batches for batch edges.
This change makes it so you can consume the StatsNode consistently independent of edge type.