Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP based subscriptions #562

Merged
merged 1 commit into from
Jun 1, 2016
Merged

Support HTTP based subscriptions #562

merged 1 commit into from
Jun 1, 2016

Conversation

nathanielc
Copy link
Contributor

@nathanielc nathanielc commented May 18, 2016

This PR depends on influxdata/influxdb#6655

TODO:

  • CHANGELOG
  • Do not hardcode port 9092

@allen13
Copy link

allen13 commented May 31, 2016

Looking forward to this feature!

@nathanielc nathanielc changed the title Initial work to support HTTP based subscriptions Support HTTP based subscriptions May 31, 2016
# and `udp-bind = "hostname_or_ip"`,
# then the UDP port will be bound to `hostname_or_ip:1234`
# The default empty value will bind to all addresses.
udp-bind = ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rossmcdonald Since I was in this code today, I added this option so that the UDP bind address is configurable separate from the hostname config option. Now the default is to bind to all addresses, which should work well.

UDP bind address configurable
HTTP port is determined from [http] bind address config
@nathanielc nathanielc merged commit 8ab770d into master Jun 1, 2016
@nathanielc nathanielc deleted the nc-http-subs branch June 1, 2016 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants