Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerta] Do not set status, fix rawData and default severity is indeterminate #456

Merged
merged 2 commits into from
Apr 12, 2016
Merged

[Alerta] Do not set status, fix rawData and default severity is indeterminate #456

merged 2 commits into from
Apr 12, 2016

Conversation

satterly
Copy link
Contributor

Some minor fixes to the Alerta integration...

  • let the Alerta server determine the alert status otherwise alerts that have been acknowledged in the console will be incorrectly modified
  • change incorrect data attribute to rawData
  • default severity should be indeterminate otherwise automatic status changes don't work as expected
  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Let the Alerta server determine the alert status otherwise alerts
that have been acknowledged in the console will be incorrectly
modified.
@satterly satterly changed the title Do not set status, fix rawData and default severity is indeterminate [Alerta] Do not set status, fix rawData and default severity is indeterminate Apr 12, 2016
@nathanielc
Copy link
Contributor

@satterly Thanks for the PR, can you help me understand how Alerta determines the status?

@@ -31,6 +31,7 @@ Example UDF config for a socket based UDF.
- [#441](https://github.com/influxdata/kapacitor/issues/441): Fix panic in UDF code.
- [#429](https://github.com/influxdata/kapacitor/issues/429): BREAKING: Change TICKscript parser to be left-associative on equal precedence operators. For example previously this statement `(1+2-3*4/5)` was evaluated as `(1+(2-(3*(4/5))))`
which is not the typical/expected behavior. Now using left-associative parsing the statement is evaluated as `((1+2)-((3*4)/5))`.
- n/a: Fixes Alerta integration to let server set status, fix `rawData` attribute and set default severity to `indeterminate`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you have on open PR can you reference the PR here in the CHANGELOG?

@satterly
Copy link
Contributor Author

@nathanielc From the Alerta docs website...

Alerta is called state-based because it will automatically change the alert status based on the current and previous severity of alerts and subsequent user actions.

The Alerta API will:

  • only show the most recent state of any alert
  • change the status of an alert to closed if a normal, ok or cleared is received
  • change the status of a closed alert to open if the event reoccurs
  • change the status of an acknowledged alert to open if the new severity is higher than the current severity
  • update the severity and other key attributes of an alert when a more recent alert is received (see correlation)
  • update the trendIndication attribute based on previousSeverity and current severity with either moreSevere, lessSevere or noChange
  • update the history log following a severity or status change (see alert history)

See http://docs.alerta.io/en/latest/server.html#state-based-browser for more info.

@nathanielc
Copy link
Contributor

@satterly Perfect. Thanks.

@nathanielc nathanielc merged commit dc2967a into influxdata:master Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants