-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor change to build.py #262
Conversation
+1 on green, Thanks a ton for keeping these in sync. Have you tried the kapacitor -> influxdb port yet? do you need any help? |
@nathanielc I merged the bulk of the changes yesterday with influxdata/influxdb#5596, but this should be the last one needed to get everything in sync. I think I have everything under control for now, but I'll let you know if things get too complicated. |
Great, second commit looks good too. Thanks |
Hmm, failure here was:
Which was originally getting skipped, but is now handled. I don't know why there would be un-committed changes in the directory, though. |
Go generate must have changed some files, meaning the committed ones are out of date with the source of the generated files. Which is a valid reason to stop the build. I'll see if I can figure out what is up. |
Same failure. I'm guessing this is from the changes made by |
Ah, that makes sense. |
@nathanielc I added debug output to the build command. It's more verbose and shows the underlying commands being run, which should hopefully help a little with debugging. Let me know if you have any concerns, or want to leave it as-is. |
Files that changed are:
|
Hmm, I'll fix that.... On Fri, Feb 26, 2016 at 11:31 AM, Ross McDonald notifications@github.com
Nathaniel Cook InfluxData.com http://influxdata.com/ |
35b3216
to
6d135f6
Compare
@rossmcdonald I fixed the go generate issue, now something else is broken. Looks like the test deps didn't get installed. |
- updated the test function - cleaned up 'go generate' call - added debug output to circle builds - added more verbose debug output to commands
a1e46bb
to
2ded87b
Compare
@nathanielc Test dependency issue resolved! I also squashed a few commits. Assuming the latest check passes, I think this is ready to go. |
This change brings back parity to InfluxDB build script.