Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: switch to github.com/golang-jwt/jwt #2601

Merged
merged 1 commit into from
Aug 2, 2021
Merged

security: switch to github.com/golang-jwt/jwt #2601

merged 1 commit into from
Aug 2, 2021

Conversation

docmerlin
Copy link
Contributor

This switches our jwt library because of a security bug in
github.com/dgrijalva/jwt-go

@docmerlin
security: switch to github.com/golang-jwt/jwt
d3efdf8 
This switches our jwt library because of a security bug in
github.com/dgrijalva/jwt-go
@docmerlin docmerlin mentioned this pull request Aug 2, 2021
Closed
jdstrand
jdstrand approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@jdstrand jdstrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tried to build this or otherwise look at the PR deeply (so may want to have someone else take a look), but it has the shape used in PRs for other projects and looks the way I would expect it to look. Thanks!

@docmerlin docmerlin merged commit 5064b13 into master Aug 2, 2021
@docmerlin docmerlin deleted the security/jwt branch August 2, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdstrand jdstrand jdstrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@docmerlin @jdstrand