-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(package): set rpm user and group to create files with correct owner #2186
Conversation
@nathanielc That option actually makes rpm create every file with that ownership, so, for example:
I can set finer grained permissions by using
And change only Tested on CentOS 7. |
I also realised, that no post install script is run when |
@affo Let's use the finer grained permissions. |
Tested on CentOS:
Also tested the
|
mkdir -p $LOG_DIR | ||
chown -R -L kapacitor:kapacitor $LOG_DIR | ||
mkdir -p $DATA_DIR | ||
chown -R -L kapacitor:kapacitor $DATA_DIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved lines here to preserve previous behavior in non REHL distros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Can you add an entry to the CHANGELOG for the fix?
@nathanielc done |
This PR makes rpm create files and directories with the right owner (user and group).
This makes it possible to avoid changing ownership after install and so breaking verification (
rpm -V ...
).Required for all non-trivial PRs
Required only if applicable
You can erase any checkboxes below this note if they are not applicable to your Pull Request.