fix: multi same-type discovery configs #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flisky
force-pushed
the
master
branch
2 times, most recently
from
179ac24
to
2ff379a
Compare
|
Testcase & changelog added. Also fix a @nathanielc, can you please take a look? Thanks! PS. the ci error seems irrelative. |
because the `closing` channel handling in `scrape` also wants the mutex lock.
|
Anyone here? This bug is annoying, and we have to fork our repository and run multi processes. |
docmerlin
approved these changes
May 12, 2020
|
@flisky sorry it has taken so long to get to this PR. Thanks for adding it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LAST one will be registered multi-times.
See Range Gotcha :)