Update example config to have default discoverer sections that are disabled #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
nc-example-config
branch
from
c854dca
to
0e6c9d3
Compare
goller
approved these changes
May 22, 2017
nathanielc
added a commit
that referenced
this pull request
May 22, 2017
Update example config to have default discoverer sections that are disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using ENV var to override configuration only works for slices if there is already a entry in the slice.
Solution
This changes the default configuration to include an entry for each section. Each entry still default to being disabled which makes it equivalent with the exception that ENV vars can now be used to enabled and otherwise manipulate the default entry.