Fix bug where env overrides stopped working for the k8s config section #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goller
approved these changes
May 22, 2017
desa
approved these changes
May 22, 2017
nathanielc
force-pushed
the
nc-fix-k8s-env-config
branch
from
2cb86b1
to
3ce9edb
Compare
nathanielc
added a commit
that referenced
this pull request
May 22, 2017
Fix bug where env overrides stopped working for the k8s config section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Env vars like
KAPACITOR_KUBERNETES_..previously worked but currently do not.Solution
Since the Kubernetes config section can be both a single section or a list of sections we have added support for implict 0 indexes in the env var names. This new behavior must be explicitly enabled for each configuration section that needs it. Currently on the kubernetes section needs this change.