Enable markdown in slack attachments #251 #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanielc Does this pull can be merged ? |
|
@xuqingfeng Sorry for the really long delay. We have been in freeze mode for the 1.1 release. That is over now and I can take a look at this PR. My first question is, should this be a user option to enable mark down formatting? |
|
Everyone loves |
OK, I agree :) Can you update the test here to reflect this change? |
|
@nathanielc done |
|
@xuqingfeng Everyting looks good to go. Can you rebase off master and add a CHANGELOG entry? Then I can merge on green. Thanks! |
|
@nathanielc sure Could you check if it's ok? |
nathanielc
added a commit
that referenced
this pull request
Dec 6, 2016
Enable markdown in slack attachments #251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs