fix some issues found in review

influxdata · Jul 31, 2017 · f6399e1 · f6399e1
1 parent 8f517a2
commit f6399e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/services/udf/service.go b/services/udf/service.go
@@ -111,6 +111,9 @@ func (s *Service) Refresh(name string) error {
 }
 
 func (s *Service) loadUDFInfo(name string) (udf.Info, error) {
+	// loadUDFInfo creates a UDF connection outside the context of a task or node
+	// because it only makes the Info request and never makes an Init request.
+	// As such it does not need to provide actual task and node IDs.
 	u, err := s.Create(name, "", "", s.logger, nil)
 	if err != nil {
 		return udf.Info{}, err

diff --git a/udf/agent/server.go b/udf/agent/server.go
@@ -91,7 +91,7 @@ func (s *Server) run() error {
 	errC := make(chan error, 1)
 	s.wg.Add(1)
 	go func() {
-		s.wg.Done()
+		defer s.wg.Done()
 		for {
 			conn, err := s.listener.Accept()
 			if err != nil {