Support customizing how calls are handled in reduce and eval #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jsternberg
force-pushed
the
js-call-valuer
branch
2 times, most recently
from
78ab01e to
62ca548
Compare
2 tasks
jsternberg
requested review from
stuartcarnie
and removed request for
benbjohnson
This adds the CallValuer interface so it can be used to evaluate a function call. This allows influxql to remain agnostic about how a function call is used and is used directly to support math function calls such as the trigonometry functions without directly implementing the functions in this library.
jsternberg
force-pushed
the
js-call-valuer
branch
from
62ca548 to
6540eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CallValuer interface so it can be used to evaluate a
function call.
This allows influxql to remain agnostic about how a function call is
used and is used directly to support math function calls such as the
trigonometry functions without directly implementing the functions in
this library.