Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable casting values from a subquery #9665

Merged
merged 1 commit into from
Mar 31, 2018
Merged

Conversation

jsternberg
Copy link
Contributor

This also fixes the cursor system to abandon iterators that will not
produce meaningful results since the variables are all unknown types.

This creates a weird behavior that existed in previous releases and we
are keeping here for backwards compatibility. If a subquery referenced a
field that didn't exist in the subquery, it will return nothing. But, if
there are two subqueries and one of them has the field exist and the
other doesn't, the second will return all null values.

Fixes #9624.

This also fixes the cursor system to abandon iterators that will not
produce meaningful results since the variables are all unknown types.

This creates a weird behavior that existed in previous releases and we
are keeping here for backwards compatibility. If a subquery referenced a
field that didn't exist in the subquery, it will return nothing. But, if
there are two subqueries and one of them has the field exist and the
other doesn't, the second will return all null values.
@ghost ghost assigned jsternberg Mar 30, 2018
@ghost ghost added the review label Mar 30, 2018
@jsternberg jsternberg requested a review from stuartcarnie March 30, 2018 22:01
@jsternberg jsternberg merged commit a383dc9 into master Mar 31, 2018
@jsternberg jsternberg deleted the js-9624-subquery-cast branch March 31, 2018 16:16
@ghost ghost removed the review label Mar 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value not converted into integer from sub query
2 participants