-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow SHOW SERIES kill #9586
Allow SHOW SERIES kill #9586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change I made to Shards#CreateIterator
will also need to wrap the SeriesPointIterator
in an InterruptIterator
@benbjohnson would this also need to be wrapped? Lines 1254 to 1274 in 7b1c0e7
|
@stuartcarnie I don't think that section needs to be wrapped. I believe it gets wrapped by |
Previously, large
SHOW SERIES
queries would block until merging was complete before being interrupted. Interruption checks have been added to the iterator and the merge loop. I also tried adding interruption checks to the sort phase but it's difficult to break out ofsort.Sort()
upon interruption.