Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing Store.Close() unlock. #9513

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Fix missing Store.Close() unlock. #9513

merged 1 commit into from
Mar 6, 2018

Conversation

benbjohnson
Copy link
Contributor

Add a missing sync.Mutex.Unlock() to Store.Close()

@benbjohnson benbjohnson self-assigned this Mar 6, 2018
@benbjohnson benbjohnson requested review from jwilder and e-dard March 6, 2018 17:41
@ghost ghost added the review label Mar 6, 2018
e-dard
e-dard approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benbjohnson benbjohnson merged commit 548e244 into master Mar 6, 2018
@ghost ghost removed the review label Mar 6, 2018
@benbjohnson benbjohnson deleted the bj-fix-missing-store-unlock branch April 20, 2018 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-dard e-dard e-dard approved these changes

@jwilder jwilder Awaiting requested review from jwilder

Assignees

@benbjohnson benbjohnson

Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benbjohnson @e-dard