Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TSI log file recovery. #9510

Merged
merged 1 commit into from
Mar 5, 2018
Merged

Fix TSI log file recovery. #9510

merged 1 commit into from
Mar 5, 2018

Conversation

benbjohnson
Copy link
Contributor

Adds additional tsi1.LogFile recovery and unit tests.

@benbjohnson benbjohnson added this to the 1.5.0 milestone Mar 5, 2018
@benbjohnson benbjohnson self-assigned this Mar 5, 2018
@benbjohnson benbjohnson requested review from jwilder and e-dard March 5, 2018 20:29
@ghost ghost added the review label Mar 5, 2018
@jwilder
Copy link
Contributor

jwilder commented Mar 5, 2018 

--- FAIL: TestLogFile_Open (0.11s)
10040    --- FAIL: TestLogFile_Open/Truncate (0.08s)
10041    	log_file_test.go:187: truncate C:\Users\appveyor\AppData\Local\Temp\1\tsi1-log-file-821362195: Access is denied.
10042    --- FAIL: TestLogFile_Open/ChecksumMismatch (0.03s)
10043    	log_file_test.go:229: truncate C:\Users\appveyor\AppData\Local\Temp\1\tsi1-log-file-984766909: Access is denied.

jwilder
jwilder approved these changes Mar 5, 2018
View reviewed changes
Copy link
Contributor

@jwilder jwilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but looks like windows build is failing for the test.

@benbjohnson benbjohnson force-pushed the bj-fix-tsi-recovery branch from 710adfd to 8e62e8d Compare March 5, 2018 21:49
@benbjohnson
Copy link
Contributor Author

@jwilder I forgot that Windows doesn't let you truncate an open file. I switched it in 8e62e8d to simply move the write head so it would overwrite the bad data.

@benbjohnson benbjohnson merged commit 520dbc1 into master Mar 5, 2018
@ghost ghost removed the review label Mar 5, 2018
@benbjohnson benbjohnson deleted the bj-fix-tsi-recovery branch March 5, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilder jwilder jwilder approved these changes

@e-dard e-dard Awaiting requested review from e-dard

Assignees

@benbjohnson benbjohnson

Labels
kind/bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@benbjohnson @jwilder