Evaluate a true boolean literal when calculating tag sets #9491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This should fix #9290 in 1.5. It does not backport cleanly to 1.4 since this specific area of the code was modified for TSI. The fix for 1.4 is pretty similar though and is partially shared with this change. This PR does not require, but is helped out by influxdata/influxql#11. While that PR makes this one unnecessary, I think that this functionality is still useful to reduce confusion when coding. |
e-dard
approved these changes
Feb 28, 2018
tsdb/index.go
Outdated
| case *influxql.BooleanLiteral: | ||
| if expr.Val { | ||
| return is.measurementSeriesIDIterator(name) | ||
| } else { |
There was a problem hiding this comment.
You can drop the else and just return nil, nil
tsdb/index/inmem/meta.go
Outdated
| case *influxql.BooleanLiteral: | ||
| if n.Val { | ||
| return m.SeriesIDs(), nil, nil | ||
| } else { |
There was a problem hiding this comment.
Again, else can be removed.
jsternberg
force-pushed
the
js-9290-index-boolean-literals
branch
from
a00ad2e to
4b58218
Compare
jsternberg
force-pushed
the
js-9290-index-boolean-literals
branch
from
4b58218 to
6baf354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9290.