Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Prometheus metrics HTTP endpoint #9218

Merged
merged 2 commits into from
Dec 12, 2017
Merged

add Prometheus metrics HTTP endpoint #9218

merged 2 commits into from
Dec 12, 2017

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Dec 11, 2017

This PR adds a Prometheus http://<host:port>/metrics endpoint. It is configured to produce the default Go metrics. Follow up PRs will add additional InfluxDB metrics.

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

@ghost ghost assigned stuartcarnie Dec 11, 2017
@ghost ghost added the review label Dec 11, 2017
@stuartcarnie stuartcarnie requested a review from e-dard December 11, 2017 15:56
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stuartcarnie stuartcarnie merged commit cfc7428 into master Dec 12, 2017
@ghost ghost removed the review label Dec 12, 2017
@stuartcarnie stuartcarnie deleted the sgc-prometheus branch December 12, 2017 14:40
@dprittie
Copy link

is this compatible with Prometheus 2.0.0?

@stuartcarnie
Copy link
Contributor Author

stuartcarnie commented Jan 12, 2018

@dprittie this endpoint provides metric data and there is no indication this format has changed for Prometheus 2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants