Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat #9212: add ability to generate shard digests #9213

Merged
merged 4 commits into from
Dec 13, 2017
Merged

feat #9212: add ability to generate shard digests #9213

merged 4 commits into from
Dec 13, 2017

Conversation

dgnorton
Copy link
Contributor

@dgnorton dgnorton commented Dec 8, 2017 •
edited
Loading

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

@ghost ghost assigned dgnorton Dec 8, 2017
@ghost ghost added the review label Dec 8, 2017
@dgnorton dgnorton requested a review from jwilder December 8, 2017 19:54
jwilder
jwilder suggested changes Dec 8, 2017
View reviewed changes
Copy link
Contributor

@jwilder jwilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bring the digest reader and writer tests over as well?

@dgnorton
Copy link
Contributor Author

dgnorton commented Dec 8, 2017

@jwilder done

@dgnorton dgnorton force-pushed the dn-generate-digests branch from af27085 to aa248e2 Compare December 13, 2017 14:26
@dgnorton dgnorton force-pushed the dn-generate-digests branch from aa248e2 to 253ea7c Compare December 13, 2017 14:29
@dgnorton dgnorton merged commit 44a06e2 into master Dec 13, 2017
@ghost ghost removed the review label Dec 13, 2017
@dgnorton dgnorton deleted the dn-generate-digests branch December 13, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilder jwilder jwilder approved these changes

Assignees

@dgnorton dgnorton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dgnorton @jwilder