Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.10 omits Content-Type header if server response has no body #9208

Merged
merged 2 commits into from
Dec 8, 2017

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Dec 8, 2017

Update error response to exclude Content-Type if body length is 0

https://tip.golang.org/doc/go1.10#net/http

The content-serving handlers also now omit the Content-Type header
when serving zero-length content.

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

https://tip.golang.org/doc/go1.10#net/http

> The content-serving handlers also now omit the Content-Type header
when serving zero-length content.
@stuartcarnie stuartcarnie requested a review from e-dard December 8, 2017 02:20
@ghost ghost assigned stuartcarnie Dec 8, 2017
@ghost ghost added the review label Dec 8, 2017
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stuartcarnie stuartcarnie merged commit 0be32d5 into master Dec 8, 2017
@ghost ghost removed the review label Dec 8, 2017
@stuartcarnie stuartcarnie deleted the sgc-client branch December 8, 2017 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants