fix descending and range queries via IFQL RPC API #9105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mark-rushakoff
suggested changes
Nov 14, 2017
| @@ -0,0 +1 @@ | |||
| package tsm1 | |||
tsdb/engine/tsm1/engine_test.go
Outdated
| } | ||
| } | ||
|
|
||
| // Ensure engine can create an ascending cursor for tsm values. |
There was a problem hiding this comment.
descending cursor in this test
CHANGELOG.md
Outdated
| @@ -1,3 +1,9 @@ | |||
| ## v1.4.1 [unreleased] | |||
There was a problem hiding this comment.
Since we're just doing a quick patch release for this, can you go ahead and set the date to 2017-11-13?
stuartcarnie
force-pushed
the
sgc-1.4-backport
branch
from
3b99381 to
3ba39a1
Compare
* did not handle cached values correctly * sort shards by time in either ascending or descending order depending on the RPC request ordering to ensure they are traversed in the correct order. (cherry picked from commit 2e04e87) 4039a76 Stuart Carnie <stuart.carnie@gmail.com> on 11/13/17 at 4:07 PM committed on 11/13/17 at 5:22 PM
stuartcarnie
force-pushed
the
sgc-1.4-backport
branch
from
3ba39a1 to
5d4f570
Compare
mark-rushakoff
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
order depending on the RPC request ordering to ensure they
are traversed in the correct order.
(cherry picked from commit 2e04e87)
Required for all non-trivial PRs