don't open log file before truncate file #906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| func newLog(logFileName string, config *configuration.Configuration) (*log, error) { | ||
| size, err := checkAndRepairLogFile(logFileName) | ||
| if nil != err { |
There was a problem hiding this comment.
While this is an admirable programming style to prevent the classic bug of assignment instead of comparison, it is not possible in Go to make this mistake. The compiler won't let you do it.
http://play.golang.org/p/0aO2Gqwupe
http://play.golang.org/p/YoYqojbVU5
I suggest you follow the standard style.
|
I have modified according to your suggestions |
jvshahid
pushed a commit
that referenced
this pull request
Sep 8, 2014
jvshahid
force-pushed
the
master
branch
2 times, most recently
from
987efd5 to
5e9750f
Compare
toddboom
changed the title
|
I think the changes for v0.9.0 are so significant that this won't end up getting merged in. Thanks for the hard work, @runner-mei! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failed to trancate file while file has opened on some filesystem(on the win32), don't open log file before trancate file.
I hope influxdb can be ported to win32 platform, I have more pull request, which is one of。
#839 is duplcate, I close it