Update the zap logger dependency #9055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jsternberg
force-pushed
the
js-update-zap-logger
branch
3 times, most recently
from
30c4605 to
43a2622
Compare
jsternberg
force-pushed
the
js-update-zap-logger
branch
2 times, most recently
from
b7dc1b6 to
3eabc6e
Compare
mark-rushakoff
suggested changes
Nov 10, 2017
| zap.NewTextEncoder(), | ||
| zap.Output(os.Stderr), | ||
| ) | ||
| cmd.Logger = logger.New(os.Stderr) |
There was a problem hiding this comment.
This should be cmd.Stderr.
jsternberg
force-pushed
the
js-update-zap-logger
branch
from
3eabc6e to
0eb3f5a
Compare
The previous sha was taken from a revision on a devel branch that I thought would continue staying in the tree after it was merged. That revision was rebased away and the API was changed for the logger. This updates the usage of the logger and adds a simple package for constructing the base logger. The 1.0 version of zap changed the format of the default console logger so this change moves over to this new logger instead of attempting to retain backwards compatibility with the old format.
jsternberg
force-pushed
the
js-update-zap-logger
branch
from
0eb3f5a to
0b7c56b
Compare
mark-rushakoff
approved these changes
Nov 10, 2017
|
Race tests are the ones that failed again. I'm going to merge this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous sha was taken from a revision on a devel branch that I
thought would continue staying in the tree after it was merged. That
revision was rebased away and the API was changed for the logger.
This updates the usage of the logger and adds a simple package for
constructing the base logger.