Update to go 1.9.2 #9021
Update to go 1.9.2 #9021
Conversation
ghost
assigned 
|
@jwilder my only suggestion would be we switch out the 1.9 test runner for a 1.10 one. The 1.10 branch is open. I assume Circle doesn't fail the build if the testing-future-go-version runner fails does it? |
|
There's a couple other mentions of Go versions that need to be updated. I'm locating those now and I'll drop them in here. |
|
@e-dard It does fail the build. |
|
@jwilder there's some go 1.8.4 occurrences in CONTRIBUTING.md that need updated, then I think this PR is good to go. |
|
@mark-rushakoff Fixed |
| @@ -21,7 +21,7 @@ RUN gem install fpm | |||
|
|
|||
| # Install go | |||
| ENV GOPATH /root/go | |||
| ENV GO_VERSION 1.9.1 | |||
| ENV GO_VERSION 1.9.2 | |||
There was a problem hiding this comment.
The _go19 file isn't really necessary - it should be _go110 but I'm not sure whether that's available yet. I'm fine leaving the file around so we don't have to undo and redo the work to have circle test the next Go version.
There was a problem hiding this comment.
Yeah. I left it as is since I couldn't find a go1.10.
|
@jwilder dang. I guess we should probably hold the 1.10 runner off until the branch is a bit more stable. |
jwilder
force-pushed
the
jw-go192
branch
2 times, most recently
from
352d0c1 to
d1edd76
Compare
This doesn't appear to actually do anything and just rebuilds all the images for some reason.
Required for all non-trivial PRs
Updates to go1.9.2