Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock when calling SeriesIDsAllOrByExpr #8766

Merged
merged 2 commits into from
Aug 29, 2017
Merged

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Aug 29, 2017

  • WalkWhereForSeriesIDs may call SeriesIDs, which may attempt to
    upgrade from a RLock to a Lock, causing the deadlock
Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

* WalkWhereForSeriesIDs may call SeriesIDs, which may attempt to
  upgrade from a `RLock` to a `Lock`, causing the dead lock
@stuartcarnie stuartcarnie changed the title release lock to avoid dead lock when calling WalkWhereForSeriesIDs release lock to avoid deadlock when calling WalkWhereForSeriesIDs Aug 29, 2017
@stuartcarnie stuartcarnie changed the title release lock to avoid deadlock when calling WalkWhereForSeriesIDs Fix deadlock when calling SeriesIDsAllOrByExpr Aug 29, 2017
@stuartcarnie stuartcarnie requested a review from jwilder August 29, 2017 23:16
@rbetts rbetts self-assigned this Aug 29, 2017
@stuartcarnie stuartcarnie removed the request for review from jwilder August 29, 2017 23:38
@stuartcarnie stuartcarnie merged commit dd01132 into master Aug 29, 2017
@stuartcarnie stuartcarnie deleted the sgc-inmem-deadlock branch August 29, 2017 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants