Refactor how results are returned to the client #8725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes the refactor from #8477, but rebased to resolve merge conflicts and it removes the new response format. So this just refactors the internal structure of how results are constructed instead of adding additional functionality on top of that. |
jsternberg
force-pushed
the
js-refactor-result-structure
branch
3 times, most recently
from
373b9da to
74e4b84
Compare
jsternberg
force-pushed
the
js-refactor-result-structure
branch
from
74e4b84 to
693d902
Compare
This refactors the internal result returning system to match more closely how we iterative return points between result sets, series, and rows within the series. It uses the updated terminology rather than older terminology that no longer matches how we refer to things in the documentation or within the query engine. The refactor moves the aggregation and chunking behavior from `influxql.Emitter` to the HTTP service so that behavior is isolated to one location rather than sprinkled around in multiple locations.
jsternberg
force-pushed
the
js-refactor-result-structure
branch
from
693d902 to
3a96add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the internal result returning system to match more
closely how we iterative return points between result sets, series, and
rows within the series. It uses the updated terminology rather than
older terminology that no longer matches how we refer to things in the
documentation or within the query engine.
The refactor moves the aggregation and chunking behavior from
influxql.Emitterto the HTTP service so that behavior is isolated toone location rather than sprinkled around in multiple locations.