Fix deadlock when deleting measurement and writing to it #8714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilder
force-pushed
the
jw-delete-deadlock
branch
from
337a4d0 to
0d33dd0
Compare
The OnReplace func ends up trying to acquire locks on MeasurementFields. When its called via snapshotting, this can deadlock because the snapshotting goroutine also holds an RLock on the engine. If a delete measurement calls is run at the right time, it will lock the MeasurementFields and try to acquire a lock on the engine to disable compactions. This creates a deadlock. To fix this, the OnReplace callback is moved to a function param to allow only Replace calls as part of a compaction to invoke it as opposed to both snapshotting and compactions. Fixes #8713
jwilder
force-pushed
the
jw-delete-deadlock
branch
from
0d33dd0 to
035b211
Compare
jwilder
force-pushed
the
jw-delete-deadlock
branch
from
035b211 to
a393458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
The OnReplace func ends up trying to acquire locks on MeasurementFields. When
its called via snapshotting, this can deadlock because the snapshotting goroutine
also holds an RLock on the engine. If a delete measurement calls is run at the
right time, it will lock the MeasurementFields and try to acquire a lock on the engine
to disable compactions. This creates a deadlock.
To fix this, the OnReplace callback is moved to a function param to allow only Replace
calls as part of a compaction to invoke it as opposed to both snapshotting and compactions.
Fixes #8713