Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefix partial write errors with partial write: #8338

Merged
merged 1 commit into from
Apr 28, 2017
Merged

prefix partial write errors with partial write: #8338

merged 1 commit into from
Apr 28, 2017

Conversation

stuartcarnie
Copy link
Contributor

NOTE: parser errors (via http API) are also transformed into
PartialWriteError

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

@stuartcarnie
prefix partial write errors with partial write:
e25400b 
NOTE: parser errors (via http API) are also transformed into
PartialWriteError
@stuartcarnie stuartcarnie requested a review from jwilder April 28, 2017 20:03
@stuartcarnie stuartcarnie merged commit 8e597ae into 1.2 Apr 28, 2017
@stuartcarnie stuartcarnie deleted the sgc-partial-write-error-1.2 branch May 1, 2017 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsternberg jsternberg jsternberg approved these changes

@jwilder jwilder jwilder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartcarnie @jwilder @jsternberg