Fix delete time fields creating unparseable points #8251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgnorton
reviewed
Apr 4, 2017
models/points.go
Outdated
| @@ -1919,7 +1919,13 @@ func (p *point) Delete() { | |||
| switch { | |||
| case p.it.end == p.it.start: | |||
| case p.it.end >= len(p.fields): | |||
| p.fields = p.fields[:p.it.start] | |||
| // If we're not deleting first field, trim the comma | |||
There was a problem hiding this comment.
Should this be if we're not deleting the last field?
There was a problem hiding this comment.
Switched to use bytes.TrimSuffix
If a field was named time was written and was subsequently dropped, it could leave a trailing comma in the series key causing it to fail to be parseable in other parts of the code.
joelegasse
approved these changes
Apr 4, 2017
dgnorton
approved these changes
Apr 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a field was named time was written and was subsequently dropped,
it could leave a trailing comma in the series key causing it to fail
to be parseable in other parts of the code.
Required for all non-trivial PRs