Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return errors in CSV responses #8097

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

connor4312
Copy link
Contributor

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

Previously, errors that happen when asking for CSV responses would be eaten; a 400 response would be sent back, but the body would be blank without any details returned to the caller. This modifies the writer to return an error if one occurred. For example:

$ curl -s localhost:8086/query --data-urlencode db=influx_test_db --data-urlencode "q=select * from h2o_quality limit wut" -H Accept:'text/csv'
error
"error parsing query: found wut, expected integer at line 1, char 33"

@jsternberg
Copy link
Contributor

Can you rebase this and put this as a bugfix for 1.3? Thanks.

@jsternberg
Copy link
Contributor

Also feel free to give yourself some credit in the changelog. Something like "Thanks ." You can see other examples in the changelog.

@jsternberg
Copy link
Contributor

Ping.

@jsternberg
Copy link
Contributor

@connor4312 I'm going to rebase your change for you so this can be merged. I hope that's OK. Thank you for your contribution.

@jsternberg jsternberg force-pushed the return-errors-in-csv branch from 7e2e96d to 4459e1e Compare July 25, 2017 14:44
@connor4312
Copy link
Contributor Author

Sure. Sorry for the lack of followup. Let me know if you'd like me to do anything further here.

@jsternberg jsternberg merged commit fe1167c into influxdata:master Jul 25, 2017
@jsternberg
Copy link
Contributor

No problem! All merged now. Whenever we do a 1.4, it will be included.

@connor4312
Copy link
Contributor Author

Awesome, thanks!

@connor4312 connor4312 deleted the return-errors-in-csv branch July 25, 2017 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants