Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always force the file inside the tarball owned by root #7949

Merged
merged 1 commit into from
Oct 3, 2017
Merged

always force the file inside the tarball owned by root #7949

merged 1 commit into from
Oct 3, 2017

Conversation

lfarkas
Copy link
Contributor

@lfarkas lfarkas commented Feb 5, 2017 •
edited by rossmcdonald
Loading

similar to influxdata/telegraf#1704

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

@jwilder
Copy link
Contributor

jwilder commented Mar 21, 2017

@rossmcdonald can you take a look?

@jwilder jwilder requested a review from rossmcdonald March 21, 2017 19:57
@jwilder
Copy link
Contributor

jwilder commented Mar 21, 2017

@lfarkas Is there an issue logged that this PR fixes?

@lfarkas
Copy link
Contributor Author

lfarkas commented Mar 21, 2017

@jwilder no there is not.

@jwilder
Copy link
Contributor

jwilder commented Mar 21, 2017

Can you elaborate on what it is fixing? It's not clear why this change is needed.

@lfarkas
Copy link
Contributor Author

lfarkas commented Mar 21, 2017

influxdata/telegraf#2337 see my 3th comment.

@jsternberg jsternberg merged commit 920b2be into influxdata:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossmcdonald rossmcdonald rossmcdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfarkas @jwilder @rossmcdonald @jsternberg