Reduce write timeouts #7942
Merged
Reduce write timeouts #7942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replacing TSM files, the new files can be opened before the write lock is taken to reduce lock contention in this code path.
|
Using this patch in Production at the moment, significant performance improvement (reducing 500s to virtually nil during high read + write volumes). |
Every write to the WAL current runs and fsync before returning. When there are lot of concurrent writes, this can cause the WAL to bottleneck write throughput since fsyncs are very expensive. This changes the writeToLog to fsync on an interval to allow multiple fsyncs calls to be batched up into one. The writeToLog behavior is the same in that it won't return until an fsync has been performed.
e-dard
approved these changes
Feb 9, 2017
This was referenced Mar 15, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few changes to reduce write timeouts which can cause
500svia the HTTP API.partition.write.runtime.Gosched()was added in a few spots during compactions where this could occur to allow write goroutines to continue.FileStorelocks were modified to reduce contention while theEngineis locked.