Expand query dimensions from the subquery #7888
Merged
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-7875-expand-query-dimensions-from-subquery
branch
from
dc85bc1 to
5ac8f44
Compare
During development, I, at some point, decided that the dimensions should be expanded based on what was available rather than what was present in the subquery. I don't really know the rationale for this because I forgot, but it doesn't make sense or seem to be particularly useful. Expanding dimensions now just uses the values specified in the subquery rather than expanding to all available dimensions of the measurement in the subquery.
jsternberg
force-pushed
the
js-7875-expand-query-dimensions-from-subquery
branch
from
5ac8f44 to
92c5d33
Compare
jwilder
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During development, I, at some point, decided that the dimensions should
be expanded based on what was available rather than what was present in
the subquery. I don't really know the rationale for this because I
forgot, but it doesn't make sense or seem to be particularly useful.
Expanding dimensions now just uses the values specified in the subquery
rather than expanding to all available dimensions of the measurement in
the subquery.
Fixes the third issue in #7875.