Bind RPC to localhost by default, add to sample config #7835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilder
suggested changes
Jan 13, 2017
|
Actually, just realized this is the |
|
We should also reevaluate whether we need to use a separate port |
jwilder
suggested changes
Mar 21, 2017
CHANGELOG.md
Outdated
| @@ -45,6 +45,7 @@ The stress tool `influx_stress` will be removed in a subsequent release. We reco | |||
| - [#7585](https://github.com/influxdata/influxdb/pull/7585): Return Error instead of panic when decoding point values. | |||
| - [#7812](https://github.com/influxdata/influxdb/issues/7812): Fix slice out of bounds panic when pruning shard groups. Thanks @vladlopes | |||
| - [#7822](https://github.com/influxdata/influxdb/issues/7822): Drop database will delete /influxdb/data directory | |||
| - [#7835](https://github.com/influxdata/influxdb/pull/7835): Bind backup and restore port to localhost by default | |||
There was a problem hiding this comment.
Needs to be moved to 1.3 section now.
Also, I think we need to add a note under a configuration changes section (like prior releases) that notes the change in default value. Some people may be relying on the current default for remote backups.
Prior to this change, the default configuration would listen on all interfaces, potentially exposing the RPC to the public internet.
mark-rushakoff
force-pushed
the
mr-rpc-bind
branch
from
c1a58fc to
6f438ea
Compare
Closed
|
Finally updated the changelog and rebased, @jwilder. |
jwilder
approved these changes
May 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bind the RPC port to localhost by default so it is not potentially exposed to the public internet.
Add toplevel
bind-addressto the sample config because it was missing, and fix a couple typos in the config.