Remove the override of GOMAXPROCS #7723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-remove-gomaxprocs-override
branch
from
c4e0775 to
f905648
Compare
mark-rushakoff
approved these changes
Dec 14, 2016
This was needed when we were on go 1.4 but hasn't been needed since go 1.5. It was kept because we weren't sure if we were going to have to rollback to an older version of Go at that time and we kept it so we wouldn't forget to readd it. Now that we are on go 1.7 with go 1.4 deprecated, there is no going back so we might as well remove this so people can set GOMAXPROCS to a custom value using environment variables.
jsternberg
force-pushed
the
js-remove-gomaxprocs-override
branch
from
f905648 to
74d4745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was needed when we were on go 1.4 but hasn't been needed since go
1.5. It was kept because we weren't sure if we were going to have to
rollback to an older version of Go at that time and we kept it so we
wouldn't forget to readd it.
Now that we are on go 1.7 with go 1.4 deprecated, there is no going back
so we might as well remove this so people can set GOMAXPROCS to a custom
value using environment variables.