Add bound parameters map to Query object #7688
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #7687. Support for bound parameters was added in #6634. However, the golang client package was not updated to support the new behaviour. This PR extends the Query object to take a list of parameters, which are POSTed to the influxdb server when the query is executed.
Tests
I've added a test that the parameters are encoded, (which passes).
The following tests fail when I run
go test -v ./...
. However, this test is also failing with a clean check-out of the master repository, so I believe it is unrelated to this PR.FAIL github.com/influxdata/influxdb/tsdb/engine/tsm1 21.017s