Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default time boundaries for raw queries #7519

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

jsternberg
Copy link
Contributor

Changes the default time boundaries for raw queries so raw queries will
range until the end of time. Aggregate queries continue to have their
default end time be now().

Fixes #4461.

Changes the default time boundaries for raw queries so raw queries will
range until the end of time. Aggregate queries continue to have their
default end time be `now()`.
@jsternberg jsternberg force-pushed the js-4461-default-time-boundaries branch from 676f8a2 to f1fbb55 Compare October 25, 2016 20:09
@jwilder jwilder added this to the 1.1.0 milestone Oct 25, 2016
@jsternberg jsternberg merged commit e7629e9 into master Oct 25, 2016
@jsternberg jsternberg deleted the js-4461-default-time-boundaries branch October 25, 2016 21:22
@jsternberg
Copy link
Contributor Author

@rkuchan this change will need to be documented.

@beckettsean
Copy link
Contributor

@jsternberg is my understanding correct?

SELECT * FROM foo           # will select until max(int64)-1
SELECT MEAN(*) FROM foo     # will select until now()
SELECT MAX(*) FROM foo      # will select until now()

@jsternberg
Copy link
Contributor Author

I need to clarify the changelog since that's wrong. This is it:

SELECT * FROM foo                                   # will select until max(int64)-1
SELECT MEAN(*) FROM foo                             # will select until max(int64)-1
SELECT MAX(*) FROM foo                              # will select until max(int64)-1
SELECT MAX(*) FROM foo WHERE ... GROUP BY time(...) # will select until now()

@beckettsean
Copy link
Contributor

Thanks for the clarification, @jsternberg.

The original comment has:Aggregate queries continue to have their default end time be now(), but if SELECT MEAN(*) FROM foo doesn't use now(), should that sentence in the comment be more like Queries with a group by time continue to have the default end time of now()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants