Input plugins should retry database creation #7477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwilder
reviewed
Oct 18, 2016
| @@ -397,6 +439,9 @@ func (s *Service) processBatches(batcher *tsdb.PointBatcher) { | |||
| for { | |||
| select { | |||
| case batch := <-batcher.Out(): | |||
| // Will attempt to create database if not yet created. | |||
| s.createInternalStorage() | |||
There was a problem hiding this comment.
Shouldn't this check for an error being returned?
| case batch := <-batcher.Out(): | ||
| // Will attempt to create database if not yet created. | ||
| s.createInternalStorage() |
There was a problem hiding this comment.
Since there is nothing we can do but log the error, it seems cleaner to have createInternalStorage check for an error and log it itself.
There was a problem hiding this comment.
But then it continues on to try the write which will fail as well and tie up resources. Seems like we should abort the write here since we already know it will fail.
There was a problem hiding this comment.
Ah sorry I see what you mean. OK I'll refactor that.
e-dard
force-pushed
the
er-service-create
branch
3 times, most recently
from
3e2b5a0 to
18dfcf3
Compare
e-dard
force-pushed
the
er-service-create
branch
from
18dfcf3 to
168c91c
Compare
jwilder
approved these changes
Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
Ensure input services can be safely opened and closed #7463 needs to be merged first.
This PR changes how input plugins open. Instead of trying to create a database on open they will instead check if they have successfully created a database when processing data.
@jwilder