-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align binary math expression streams by time #7473
Conversation
@mark-rushakoff this can act as an alternative to #7464 that also implements |
ed2e75a
to
b9e9459
Compare
left *buf{{$k.Name}}Iterator | ||
right *buf{{$k.Name}}Iterator | ||
fn {{$k.name}}{{if ne $k.Name $v.Name}}{{$v.Name}}{{end}}ExprFunc | ||
points []{{$k.Name}}Point // must be size 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to have this be an array rather than a slice, so that the compiler can enforce length of 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that at first, but then I can't set it to nil when fill(none)
is specified. Oh, that reminds me. I forgot to implement fill(previous)
which is the only reason this is here to begin with.
Should this be the correct output of
|
@jsternberg wouldn't we get something like
or am I just misunderstanding? |
That's a good point, but I'm not sure I can do that as part of this PR since it's a separate part of the code. If we think that's a proper thing to do in the future, we might want to add the binary functionality now (like this PR) and then make a note in the docs that we're going to do it for the other types of queries too so it does the output that you said. |
b9e9459
to
2cd7c90
Compare
Also fills in missing values using the fill expression for any binary aggregation.
2cd7c90
to
19a61db
Compare
Also fills in missing values using the fill expression for any binary
aggregation.
Fixes #7427 and #7469.