Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mode() function & tests #7199

Merged
merged 2 commits into from
Aug 24, 2016
Merged

add mode() function & tests #7199

merged 2 commits into from
Aug 24, 2016

Conversation

jsternberg
Copy link
Contributor

No description provided.

@jsternberg jsternberg mentioned this pull request Aug 24, 2016
4 tasks
@jsternberg jsternberg self-assigned this Aug 24, 2016
@jsternberg
Copy link
Contributor Author

@agaurav before I merge this, which email do you want to use as the author for this commit? I see @opavader and @agaurav seem to be both you, but with different emails. I want to make sure the commit log has the credit given to the correct GitHub username.

@jsternberg jsternberg added this to the 1.0.0 milestone Aug 24, 2016
@jsternberg
Copy link
Contributor Author

@jwilder can I also get a thumbs up that this is OK to merge into 1.0 to be released with the next release candidate?

@agaurav
Copy link

agaurav commented Aug 24, 2016

@jsternberg I think i signed the CLA with this account (@agaurav), so please use this.

@jsternberg
Copy link
Contributor Author

Looking at the CLA responses we've gotten, I see you used @agaurav as the GitHub account name, but you used ashish@archsaber.com as the email. That email appears to be linked to your other account. Do you want to use that email with the commit or a different email?

Either one is fine with me.

@agaurav
Copy link

agaurav commented Aug 24, 2016

Yeah you can use that.

@jsternberg jsternberg merged commit 76f7333 into 1.0 Aug 24, 2016
@jsternberg jsternberg deleted the js-mode-aggregate-function branch August 24, 2016 14:23
@jwilder
Copy link
Contributor

jwilder commented Aug 24, 2016

Looks great @agaurav! This is missing a changelog entry though.

@jwilder
Copy link
Contributor

jwilder commented Aug 24, 2016

cc @nathanielc

@agaurav
Copy link

agaurav commented Aug 24, 2016

@jwilder #7207 for changelog.
Also, influxdata/docs.influxdata.com-ARCHIVE#585 for updating the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants