Concurrent series limit #7127
Merged
Concurrent series limit #7127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbjohnson
force-pushed
the
fix-series-limit
branch
from
760a488 to
53dba8d
Compare
|
LGTM 👍 |
This commit fixes the `MaxSelectSeriesN` limit which was broken by the implementation of lazy iterators. The setting previously limited the total number of series but the new implementation limits the concurrent number of series being processed.
benbjohnson
force-pushed
the
fix-series-limit
branch
from
53dba8d to
55b3e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This commit fixes the
MaxSelectSeriesNlimit which was broken by the implementation of lazy iterators. The setting previously limited the total number of series but the new implementation limits the concurrent number of series being processed./cc @jwilder @jsternberg
TODO