Implement text/csv content encoding for the response writer #7099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
js-csv-writer
branch
from
3179739 to
cb35bee
Compare
|
What about tab separated values (tsv) instead of csv? |
|
@jwilder is there a link to that? I'm not aware of that format. What's the different between tsv and csv? |
|
I would offer both TSV and CSV formats. They are similar enough to make it easy to support both. |
3 tasks
jsternberg
force-pushed
the
js-csv-writer
branch
2 times, most recently
from
b02ee22 to
b0c4ddf
Compare
|
|
CSV doesn't offer a way to separate different sheets from each other and it doesn't really have a standard format. We separate sheets with a newline so they can be imported into something like Excel or LibreOffice more easily. The number of columns for each sheet is inferred from the first returned row in each statement since they should all be the same.
jsternberg
force-pushed
the
js-csv-writer
branch
from
b0c4ddf to
a4e4996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV doesn't offer a way to separate different sheets from each other and
it doesn't really have a standard format. We add a custom "---"
separator (stolen from the YAML format) to differentiate
commands. The number of columns for each sheet is inferred from the
first returned row in each statement since they should all be the same.