Ensure CQ ID names can't clash #7080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-dard
force-pushed
the
er-cq-delimiter
branch
2 times, most recently
from
f2f1940 to
e5df971
Compare
|
|
||
| // idDelimier is used as a delimiter when creating a unique name for a | ||
| // Continuous Query. | ||
| idDelimier = string(rune(31)) // unit separator |
There was a problem hiding this comment.
Missed the t in delimiter.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all non-trivial PRs
I noticed this when reviewing another PR. Given database
foo:and CQbarthen the ID would become"foo::bar", which would clash with the case of databasefooand CQ:bar-->foo::bar.Instead we can use the control character for a unit separator.