Finish tsm file exporter #7046
Finish tsm file exporter #7046
Conversation
| } | ||
| defer reader.Close() | ||
|
|
||
| for i := 0; i < reader.KeyCount(); i++ { |
There was a problem hiding this comment.
@jwilder feels like there should be an easier way to get the data back to line protocol, but I couldn't find it. Thoughts?
There was a problem hiding this comment.
This is the best way. It arrives as a Point, but it's not stored or retrieved in that format ever again.
There was a problem hiding this comment.
Actually, the fastest way to walk the file is to use a BlockIterator and then decode each block based on the type. reader.ReadAll via keys works, but will be slower and allocates a lot of memory.
| if err != nil { | ||
| return err | ||
| } | ||
| defer reader.Close() |
There was a problem hiding this comment.
These deferred Closes won't execute until the end of writeFiles - maybe wrap the inner loop in an anonymous function?
corylanou
force-pushed
the
cjl-tsm-export
branch
6 times, most recently
from
7d53279 to
3d7a942
Compare
|
@jwilder comments addressed. Ready for review. |
| for _, value := range values { | ||
| switch typ { | ||
| case tsm1.BlockFloat64: | ||
| pairs = field + "=" + fmt.Sprintf("%v", value.Value()) |
There was a problem hiding this comment.
Will this format float64(0) as 0.0? Floats should include a decimal to ensure their types won't switch to an int inadvertently.
|
Two small things, but looks good! 👍 |
corylanou
force-pushed
the
cjl-tsm-export
branch
3 times, most recently
from
620ae1d to
968d322
Compare
|
Is this part of the 1.0 beta? |
|
@retorquere It's in the current nightlies. |
|
Ok, no issue. Is this compatible with 0.13 and could I compile it separately? Alternatively, are the nightlies usable enough to be mostly-available, and is there a clean upgrade path between 0.13? Is there a timeline for 1.0? |
|
@retorquere The upgrade bath from 0.13 is straight-forward, installing the new package over the existing 0.13 will be sufficient. Please review the Changelog before upgrading in case you want to modify the new default configuration values (particularly max-series-per-database). |
|
Thanks for the feedback, and I'm looking at that parameter now, but this is about the number of series, not taking into account the cardinality of the tags? Not that it would affect me I think; I have 3 series, each with one tag with cardinality 3, but with 70 fields. |
Add ability to export TSM files to line protocol to be imported back into another database.