Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex binary encoding for a measurement #6934

Merged
merged 1 commit into from
Jul 5, 2016

Conversation

jsternberg
Copy link
Contributor

Previously, it encoded the text representation of the regex literal
which included the surrounding slashes used in the query language. The
binary encoding should only include the exact string used to create the
regular expression.

@jsternberg jsternberg force-pushed the js-fix-regex-binary-encoding branch from 9ffd6fc to d073d44 Compare June 29, 2016 20:31
@jsternberg
Copy link
Contributor Author

@jwilder @beckettsean

@jsternberg jsternberg force-pushed the js-fix-regex-binary-encoding branch from d073d44 to 2a00abf Compare June 30, 2016 14:51
Previously, it encoded the text representation of the regex literal
which included the surrounding slashes used in the query language. The
binary encoding should only include the exact string used to create the
regular expression.
@jsternberg jsternberg force-pushed the js-fix-regex-binary-encoding branch from 2a00abf to bb060a6 Compare July 5, 2016 16:39
@e-dard
Copy link
Contributor

e-dard commented Jul 5, 2016

LGTM 👍

@jsternberg jsternberg merged commit e19cc04 into master Jul 5, 2016
@jsternberg jsternberg deleted the js-fix-regex-binary-encoding branch July 5, 2016 17:06
@timhallinflux timhallinflux added this to the 1.0.0 milestone Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants