Rename dumptsmdev to dumptsm in influx_inspect #6883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @joelegasse to be a potential reviewer |
jsternberg
force-pushed
the
js-influx-inspect-dumptsm
branch
2 times, most recently
from
a4edf74 to
13869c7
Compare
| @@ -49,7 +48,7 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
| cmdInfo(path) | |||
| case "dumptsm": | |||
| case "dumptsm", "dumptsmdev": | |||
There was a problem hiding this comment.
Can you log a warning that dumptsmdev is deprecated and to use dumptsm going forward?
|
I think |
Removes the old implementation of `dumptsm`. It was for an older version of the tsm1 files that is no longer used and now just panics when used on a tsm1 file. dumptsmdev has been renamed to `dumptsm`, but the old `dumptsmdev` command still works for compatibility.
jsternberg
force-pushed
the
js-influx-inspect-dumptsm
branch
from
13869c7 to
2a1e653
Compare
|
Yep. I removed all of the stuff |
|
👍 on green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the old implementation of
dumptsm. It was for an older versionof the tsm1 files that is no longer used and now just panics when used
on a tsm1 file. dumptsmdev has been renamed to
dumptsm, but the olddumptsmdevcommand still works for compatibility.